Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jest-worker #23077

Merged
merged 12 commits into from
Mar 16, 2021
Merged

Upgrade jest-worker #23077

merged 12 commits into from
Mar 16, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 15, 2021

This PR upgrades jest-worker and jest-cli to the latest pre-release version, also removed jest-circus which is included in Jest by default. jest-worker@next includes a fix for memory leak that we need (jestjs/jest#11187).

Fixes #22925. This will also improve the OOM issue for next dev #15855.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 16, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
buildDuration 12.8s 12.7s -95ms
nodeModulesSize 42.8 MB 43.6 MB ⚠️ +787 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
/ failed reqs 0 0
/ total time (seconds) 2.169 2.12 -0.05
/ avg req/sec 1152.6 1179.12 +26.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.384 1.429 ⚠️ +0.05
/error-in-render avg req/sec 1806.81 1749.13 ⚠️ -57.68
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.14 kB 7.14 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB
_error-af59f..582f.js gzip 3.46 kB 3.46 kB
amp-9716187d..0aa8.js gzip 536 B 536 B
hooks-107e90..74c7.js gzip 888 B 888 B
index-ac435c..ecf2.js gzip 227 B 227 B
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB
routerDirect..dc9d.js gzip 303 B 303 B
withRouter-6..0e02.js gzip 302 B 302 B
Overall change 8.64 kB 8.64 kB
Client Build Manifests
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
_buildManifest.js gzip 346 B 346 B
Overall change 346 B 346 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
index.html gzip 614 B 614 B
link.html gzip 621 B 621 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
buildDuration 14.3s 14.6s ⚠️ +269ms
nodeModulesSize 42.8 MB 43.6 MB ⚠️ +787 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.14 kB 7.14 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB
_error-af59f..582f.js gzip 3.46 kB 3.46 kB
amp-9716187d..0aa8.js gzip 536 B 536 B
hooks-107e90..74c7.js gzip 888 B 888 B
index-ac435c..ecf2.js gzip 227 B 227 B
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB
routerDirect..dc9d.js gzip 303 B 303 B
withRouter-6..0e02.js gzip 302 B 302 B
Overall change 8.64 kB 8.64 kB
Client Build Manifests
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
_buildManifest.js gzip 346 B 346 B
Overall change 346 B 346 B
Serverless bundles
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
_error.js 1.02 MB 1.02 MB
404.html 2.67 kB 2.67 kB
500.html 2.65 kB 2.65 kB
amp.amp.html 10.6 kB 10.6 kB
amp.html 1.86 kB 1.86 kB
hooks.html 1.92 kB 1.92 kB
index.js 1.02 MB 1.02 MB
link.js 1.08 MB 1.08 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.27 MB 5.27 MB

Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
buildDuration 14.2s 14.5s ⚠️ +279ms
nodeModulesSize 42.8 MB 43.6 MB ⚠️ +787 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
/ failed reqs 0 0
/ total time (seconds) 2.106 2.132 ⚠️ +0.03
/ avg req/sec 1186.87 1172.83 ⚠️ -14.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.334 1.308 -0.03
/error-in-render avg req/sec 1874.18 1911.01 +36.83
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 7.08 kB 7.08 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 60.7 kB 60.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
_app-0c62a59..94b7.js gzip 1.26 kB 1.26 kB
_error-97d24..ed28.js gzip 3.38 kB 3.38 kB
amp-2926e4c2..9ccc.js gzip 536 B 536 B
hooks-1ed65b..8908.js gzip 902 B 902 B
index-6259b6..77d8.js gzip 230 B 230 B
link-2a29128..cc6e.js gzip 1.63 kB 1.63 kB
routerDirect..862a.js gzip 306 B 306 B
withRouter-4..76fd.js gzip 302 B 302 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
_buildManifest.js gzip 322 B 322 B
Overall change 322 B 322 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js fix-upgrade-jest-worker Change
index.html gzip 585 B 585 B
link.html gzip 593 B 593 B
withRouter.html gzip 580 B 580 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "TKxN4A4T4FWKlcPCdqrQu",
+        "buildId": "C_5j6Wvu3LfdAxeEYO501",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TKxN4A4T4FWKlcPCdqrQu/_buildManifest.js"
+      src="/_next/static/C_5j6Wvu3LfdAxeEYO501/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TKxN4A4T4FWKlcPCdqrQu/_ssgManifest.js"
+      src="/_next/static/C_5j6Wvu3LfdAxeEYO501/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "TKxN4A4T4FWKlcPCdqrQu",
+        "buildId": "C_5j6Wvu3LfdAxeEYO501",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TKxN4A4T4FWKlcPCdqrQu/_buildManifest.js"
+      src="/_next/static/C_5j6Wvu3LfdAxeEYO501/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TKxN4A4T4FWKlcPCdqrQu/_ssgManifest.js"
+      src="/_next/static/C_5j6Wvu3LfdAxeEYO501/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "TKxN4A4T4FWKlcPCdqrQu",
+        "buildId": "C_5j6Wvu3LfdAxeEYO501",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TKxN4A4T4FWKlcPCdqrQu/_buildManifest.js"
+      src="/_next/static/C_5j6Wvu3LfdAxeEYO501/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TKxN4A4T4FWKlcPCdqrQu/_ssgManifest.js"
+      src="/_next/static/C_5j6Wvu3LfdAxeEYO501/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 8122b19

@shuding shuding marked this pull request as ready for review March 16, 2021 21:05
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit 1bf4cf3 into vercel:canary Mar 16, 2021
@shuding shuding deleted the fix-upgrade-jest-worker branch March 16, 2021 21:10
@TrySound
Copy link
Contributor

@timneutkens not very good. A bit older now version (14.10.1 specifically) support were dropped with "engines" fields which is hardly considered by yarn.

@TrySound
Copy link
Contributor

Not a big problem for me. Though I had to bump node first.

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
This PR upgrades `jest-worker` and `jest-cli` to the latest pre-release version, also removed `jest-circus` which is included in Jest by default. `jest-worker@next` includes a fix for memory leak that we need (jestjs/jest#11187). 

Fixes vercel#22925. This will also improve the OOM issue for `next dev` vercel#15855.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10.0.8 next/image high memory use
4 participants